Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add show search_path for pg #5328

Merged
merged 1 commit into from
Jan 10, 2025
Merged

feat: add show search_path for pg #5328

merged 1 commit into from
Jan 10, 2025
+54 −4

Conversation

yihong0618
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

part of #5271
for now pg_database is better to hold waiting for the upstream apache/datafusion#13489

this patch support pg show search_path for now seems no search path for greptime so use database instead

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@yihong0618 yihong0618 requested review from evenyag and a team as code owners January 9, 2025 11:56
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jan 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 83.88%. Comparing base (815ce59) to head (8d81fe7).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5328      +/-   ##
==========================================
- Coverage   84.15%   83.88%   -0.27%     
==========================================
  Files        1177     1181       +4     
  Lines      220202   220931     +729     
==========================================
+ Hits       185309   185332      +23     
- Misses      34893    35599     +706

killme2008
killme2008 reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation seems too complex for our needs. We should consider a simpler approach like the one used in MySQL implementation, which uses regex matching for queries and returns placeholder responses. This would be more straightforward and easier to maintain. https://github.com/GreptimeTeam/greptimedb/blob/main/src/servers/src/mysql/federated.rs

@yihong0618
Copy link
Contributor Author

yihong0618 commented Jan 10, 2025 •
edited
Loading

The implementation seems too complex for our needs. We should consider a simpler approach like the one used in MySQL implementation, which uses regex matching for queries and returns placeholder responses. This would be more straightforward and easier to maintain. https://github.com/GreptimeTeam/greptimedb/blob/main/src/servers/src/mysql/federated.rs

will take a look but I followed the command like show status

greptimedb/src/sql/src/statements/show.rs

Line 284 in 78d0fa7

pub struct ShowStatus {}
should that need to change too? if so I'd like maybe change that to this way too.

and follow the code, the search_path is not like the ederated.rs way maybe?
and it depend the database we use now in the session.

And for pg there's another command we can add too, set search_path to xxxx too

update check the mysql code, seems Show status way for now is a better way? cause it depends the _query_ctx

@killme2008
Copy link
Contributor

@yihong0618

Yes, show status doesn't need to be changed.

If we need to keep the set search_path to xxxx in session, the current implementation is good.

@yihong0618
Copy link
Contributor Author

@yihong0618

Yes, show status doesn't need to be changed.

If we need to keep the set search_path to xxxx in session, the current implementation is good.

thanks will try to implement set search_path next

killme2008
killme2008 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into GreptimeTeam:main with commit 24ea9cf Jan 10, 2025
40 checks passed
@yihong0618 yihong0618 mentioned this pull request Jan 10, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunng87 sunng87 sunng87 approved these changes

@killme2008 killme2008 killme2008 approved these changes

@evenyag evenyag Awaiting requested review from evenyag evenyag is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihong0618 @killme2008 @sunng87